Fix tests

Author: jlledom

features/step_definitions/strong_passwords_steps.rb

@@ -6,5 +6,5 @@
 end
 
 Then /^I should see the error that the password is too weak$/ do
-  assert has_content? User::STRONG_PASSWORD_FAIL_MSG
+  assert has_content? "is too short (minimum is 15 characters)"
 end

test/integration/admin/api/buyers_users_controller_test.rb

@@ -39,7 +39,7 @@ def setup
     put admin_api_account_user_path(buyer, user), params: { access_token: token_value, password: 'weakpwd' }
 
     assert_response :unprocessable_entity
-    assert_match User::STRONG_PASSWORD_FAIL_MSG, response.body
+    assert_match "is too short (minimum is 15 characters)", response.body
   end
 
   test 'update with strong password accepted when strong passwords enabled' do

test/integration/developer_portal/signup_test.rb

@@ -102,7 +102,7 @@ def test_weak_password_rejected_when_strong_passwords_enabled
       post signup_path, params: account_params(WEAK_PASSWORD)
 
       assert_response :success
-      assert_match User::STRONG_PASSWORD_FAIL_MSG, response.body
+      assert_match "is too short (minimum is 15 characters)", response.body
     end
 
     def test_strong_password_accepted_when_strong_passwords_enabled

test/integration/provider/signups_controller_integration_test.rb

@@ -109,7 +109,7 @@ def test_weak_password_rejected_when_strong_passwords_enabled
     end
 
     assert_response :success
-    assert_match User::STRONG_PASSWORD_FAIL_MSG, response.body
+    assert_match "is too short (minimum is 15 characters)", response.body
   end
 
   def test_strong_password_accepted_when_strong_passwords_enabled

test/integration/user-management-api/users_test.rb

@@ -405,7 +405,7 @@ def setup
     put admin_api_user_path(format: :xml, id: chuck.id, password: "weakpwd", password_confirmation: "weakpwd"), params: { provider_key: @provider.api_key }
 
     assert_response :unprocessable_entity
-    assert_match User::STRONG_PASSWORD_FAIL_MSG, response.body
+    assert_match "is too short (minimum is 15 characters)", response.body
   end
 
   test 'update with strong password accepted when strong passwords enabled' do

test/unit/authentication/by_password_test.rb

@@ -24,7 +24,7 @@ class WeakPasswordTest < Authentication::ByPasswordTest
       user = user_with_password.call('weakpassword')
 
       assert_not user.valid?
-      assert_equal User::STRONG_PASSWORD_FAIL_MSG, user.errors[:password].first
+      assert_equal "is too short (minimum is 15 characters)", user.errors[:password].first
     end
 
     test 'weak password must be present' do
@@ -52,7 +52,7 @@ class ExistingUsersTest < Authentication::ByPasswordTest
       @user.password = "nononono"
       @user.valid?
 
-      assert_equal User::STRONG_PASSWORD_FAIL_MSG, @user.errors[:password].first
+      assert_equal "is too short (minimum is 15 characters)", @user.errors[:password].first
     end
 
     test 'password is not validated when user is sample data' do
@@ -66,17 +66,24 @@ class ExistingUsersTest < Authentication::ByPasswordTest
 
   class ValidationsTest < Authentication::ByPasswordTest
     test 'should be valid with ASCII printable characters and longer than 15 characters' do
-      user = @buyer.users.new password: "StrongPass123-+_!$#.@", password_confirmation: "StrongPass123-+_!$#.@"
-      user.valid?
+      user = user_with_password.call('StrongPass123-+_!$#.@')
+
+      assert user.valid?
+      assert user.errors[:password].blank?
+    end
 
+    test 'should be valid with Unicode characters and longer than 15 characters' do
+      user = user_with_password.call('contraseña12345')
+
+      assert user.valid?
       assert user.errors[:password].blank?
     end
 
     test 'should be invalid if shorter than 15 characters' do
       user = user_with_password.call('Pas$123')
       user.valid?
 
-      assert_equal User::STRONG_PASSWORD_FAIL_MSG, user.errors[:password].first
+      assert_equal "is too short (minimum is 15 characters)", user.errors[:password].first
     end
 
     test 'should be invalid if password and password confirmation do not match' do
@@ -87,6 +94,41 @@ class ValidationsTest < Authentication::ByPasswordTest
     end
   end
 
+  class UnicodeNormalizationTest < Authentication::ByPasswordTest
+    test 'password is normalized to NFC before saving' do
+      # "café" with e + combining acute accent (NFD form)
+      password_nfd = "cafe\u0301_secretpass"
+      # "café" with precomposed é (NFC form)
+      password_nfc = "café_secretpass"
+
+      assert_not_equal password_nfd, password_nfc
+      assert_equal password_nfd.unicode_normalize(:nfc), password_nfc
+
+      user = user_with_password.call(password_nfd)
+      user.password_confirmation = password_nfd
+      user.save!
+
+      assert user.authenticated?(password_nfc), 'Should authenticate with NFC form'
+      assert user.authenticated?(password_nfd), 'Should authenticate with NFD form (normalized before comparison)'
+    end
+
+    test 'password length is counted after NFC normalization' do
+      # 15 characters in NFD (e + combining accent = 2 code points)
+      password_nfd = "contraseñas123".unicode_normalize(:nfd)
+      # 14 characters in NFC (ñ = 1 code point)
+      password_nfc = "contraseñas123".unicode_normalize(:nfc)
+
+      assert_equal 15, password_nfd.length
+      assert_equal 14, password_nfc.length
+
+      user = user_with_password.call(password_nfd)
+      user.password_confirmation = password_nfd
+
+      assert_not user.valid?, 'Should be invalid because NFC-normalized length is 14 (< 15)'
+      assert_equal "is too short (minimum is 15 characters)", user.errors[:password].first
+    end
+  end
+
   class MethodsTest < Authentication::ByPasswordTest
     class ValidatePasswordTest < MethodsTest
       setup do