Wow! Someone finally got it right

[forthrin]

Having tested all the failed du clones on Terminal Trove, this is the first one that actually gets it (almost) right.

Before sharing some further pointers, colors need to play well with the the user's terminal background color. Particularly with the default "Ocean" theme, #224FBC, grays are practically unreadable.

$ printf '\033]11;?\007'

[2ykwang]

thanks for the kind words and the careful report. I'll take a look and follow up here. @forthrin

[forthrin]

Thanks for the friendly follow-up. Some colors are still quite unreadable. Here are some tips:

1. Use faint for the separator line, or just replace it with a blank line

$ printf "\033[2m────────────────────────────────────────────────────────────\033[22m\n\n"

2. Use the 16 color ANSI palette for compatibility, fall back on 256 color and true color when really necessary
3. Purple on filenames is unreadable on blue and redundant since you already have ▸
4. For non-black backgrounds, use no darker gray than \033[38;5;251m
5. For clarity, always favor printing integers over float/fixed, unless the latter provide critical information.
6. Use and ✔ rather than [ ] and [X] unless everything else is ASCII.

$ printf "\033[36m \033[m ✔ \033[92m●\033[m \033[mFirefox Cache\033[m \033[96m    350 MB\033[m \033[38;5;251m    1024\033[m
\033[36m▸\033[m   \033[92m●\033[m \033[mSafari Caches\033[m \033[96m    300 MB\033[m \033[38;5;251m     512\033[m\n\n"

7. Use white on black to mimic keyboard keys, and show commands as normal color.

$ printf "\033[40m↑/k\033[m up • \033[40mspace\033[m select • …\n"

[2ykwang]

@forthrin Thanks for the detailed feedback.

Just shipped a new release with your suggestions applied. it's working well on my end, but please give it a try and let me know what you think. Not everything made it into this release, but I'll keep the rest in mind for future iterations.
Code contributions are very welcome too if you want to help out.

[forthrin]

Much better! Some further suggestions:

1.all/none isn't very useful as you rarely want to delete everything. Suggest instead the intuitive keys S, M and R to toggle the respective groups.
2. Be consistent: press Y vs y delete
3. More consistency: "Move" and "delete" are used interspersedly. Destructive actions need absolute clarity. (Also, what is the main keyboard help doing inside the dialog? :P)

╭─────────────────────────────────────╮
│                                     │
│     Confirm Deletion                │
│                                     │
│                                     │
│  Files will be moved to Trash       │
│                                     │
│  ─────────────────────────────────  │
│                                     │
│  Total 53 MB will be deleted.       │
│                                     │
│    ● Homebrew Cache          53 MB  │
│  ─────────────────────────────────  │
│                                     │
│  Items can be recovered from Trash  │
│                                     │
│     ╭──────────╮  ╭──────────╮      │
│     │  Cancel  │  │  Delete  │      │
│     ╰──────────╯  ╰──────────╯      │
│  ↑/↓ scroll • ←/→/tab switch …      │
│                                     │
╰─────────────────────────────────────╯

Suggestion:

╭─────────────────────────────────────╮
│                                     │
│          Confirm cleanup            │
│                                     │
│  ─────────────────────────────────  │
│    ● Homebrew Cache          53 MB  │
│  ─────────────────────────────────  │
│      TOTAL                   53 MB  │
│                                     │
│  ╭──────────╮  ╭─────────────────╮  │
│  │  Cancel  │  │  Move to Trash  │  │
│  ╰──────────╯  ╰─────────────────╯  │
│                                     │
│   Tip: Go to Trash to recover or    │
│   permanently delete these items    │
│                                     │
╰─────────────────────────────────────╯

[forthrin]

@2ykwang: Waiting to hear from you. Also, assigned to me by mistake. Assign back to maintainer.

[2ykwang]

@forthrin sorry for the slow reply. been heads-down on another project, so this slipped for a while.

2 and 3: agreed. the UX writing hasn't had any real attention yet, so those land.

1: agree with the idea, but the keys need some thought. there are too many bindings right now, so I want to trim the set down first, then pick something intuitive (keys common across other tools) instead of stacking S/M/R on top. might not land on exactly those, but the group-toggle direction makes sense.

probably can't do it all in one go, so I'll take it incrementally.

thanks again for flagging all this

[forthrin]

1. Yes, be thoughtful about picking keys or ways to proceed. Those were merely suggestions.

Looking forward to updates whenever you find the time and inspiration.